feat: Update jsoo build process for libbinaryen#8565
Merged
kripken merged 1 commit intoWebAssembly:mainfrom Apr 1, 2026
Merged
feat: Update jsoo build process for libbinaryen#8565kripken merged 1 commit intoWebAssembly:mainfrom
kripken merged 1 commit intoWebAssembly:mainfrom
Conversation
When WebAssembly#7995 was merged it broke our upgrade process in libbinaryen. This pr fixes our build process. JS_OF_OCAML still doesn't support esm modules however it supports es6 features, so we can safely remove `target_link_libraries(binaryen_js PRIVATE optimized "--closure-args=\"--language_out=ECMASCRIPT5\"")`. Because we are not using esm modules and jsoo doesn't support top level awaits we need to dissable async compilation.
kripken
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #7995 was merged it broke our upgrade process in libbinaryen.
This pr fixes our build process.
JS_OF_OCAML still doesn't support esm modules however it supports es6 features, so we can safely remove
target_link_libraries(binaryen_js PRIVATE optimized "--closure-args=\"--language_out=ECMASCRIPT5\"").Because we are not using esm modules and jsoo doesn't support top level awaits we need to dissable async compilation.